Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758479AbYC0DKV (ORCPT ); Wed, 26 Mar 2008 23:10:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755364AbYC0DJ7 (ORCPT ); Wed, 26 Mar 2008 23:09:59 -0400 Received: from netrider.rowland.org ([192.131.102.5]:1067 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1758027AbYC0DJz (ORCPT ); Wed, 26 Mar 2008 23:09:55 -0400 Date: Wed, 26 Mar 2008 23:09:54 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: pm list , ACPI Devel Maling List , Greg KH , Len Brown , LKML , Alexey Starikovskiy , David Brownell , Pavel Machek , Benjamin Herrenschmidt , Oliver Neukum Subject: Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4) In-Reply-To: <200803270212.36465.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 24 On Thu, 27 Mar 2008, Rafael J. Wysocki wrote: > @@ -68,22 +75,32 @@ int device_pm_add(struct device *dev) > dev->bus ? dev->bus->name : "No Bus", > kobject_name(&dev->kobj)); > mutex_lock(&dpm_list_mtx); > - if ((dev->parent && dev->parent->power.sleeping) || all_sleeping) { > - if (dev->parent->power.sleeping) > - dev_warn(dev, > - "parent %s is sleeping, will not add\n", > + if (dev->parent) { > + if (dev->parent->power.status >= DPM_SUSPENDING) { > + dev_warn(dev, "parent %s is sleeping, will not add\n", > dev->parent->bus_id); You forgot to check for dev->parent->power.status == DPM_INVALID. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/