Date: Wed, 26 Mar 2008 21:00:38 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@ozlabs.org>
Cc: <linux-kernel@vger.kernel.org>,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Give futex init a proper name
Message-Id: <20080326210038.e54b6180.akpm@linux-foundation.org>
In-Reply-To: <20080327035249.6F774DDF4D@ozlabs.org>
References: <20080327035249.6F774DDF4D@ozlabs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1282
Lines: 41

On Thu, 27 Mar 2008 14:52:15 +1100 Benjamin Herrenschmidt <benh@ozlabs.org> wrote:

> The futex init function is called init(). This is a pain in the neck
> when debugging when you code dies in ... init :-)
> 
> This renames it to futex_init().
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> 
>  kernel/futex.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-work.orig/kernel/futex.c	2008-03-27 14:50:11.000000000 +1100
> +++ linux-work/kernel/futex.c	2008-03-27 14:50:20.000000000 +1100
> @@ -2158,7 +2158,7 @@ static struct file_system_type futex_fs_
>  	.kill_sb	= kill_anon_super,
>  };
>  
> -static int __init init(void)
> +static int __init futex_init(void)
>  {
>  	u32 curval;
>  	int i;
> @@ -2194,4 +2194,4 @@ static int __init init(void)
>  
>  	return 0;
>  }
> -__initcall(init);
> +__initcall(futex_init);

heh, I seem to remember doing about fifty of these in netfilter code a
while back.

You have a way to go - there are thirty-odd just in the crypto code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/