Date: Thu, 27 Mar 2008 10:26:48 +0100
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Dmitry <dbaryshkov@gmail.com>, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org, hskinnemoen@atmel.com,
       domen.puncer@telargo.com, lethal@linux-sh.org, tony@atomide.com,
       paul@pwsan.com
Subject: Re: [PATCH 1/3] Clocklib: add generic framework for managing
 clocks.
Message-ID: <20080327102648.225d6b4f@hskinnemo-gx620.norway.atmel.com>
In-Reply-To: <20080327091810.GA32396@flint.arm.linux.org.uk>
References: <20080326154913.GA15326@doriath.ww600.siemens.net>
	<20080326155203.GA15405@doriath.ww600.siemens.net>
	<20080326170441.795fb928@hskinnemo-gx620.norway.atmel.com>
	<bc64b4640803260952s58ad0645ve11766fdfa45e785@mail.gmail.com>
	<20080327100623.34d92c84@hskinnemo-gx620.norway.atmel.com>
	<20080327091810.GA32396@flint.arm.linux.org.uk>
Organization: Atmel Norway
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1369
Lines: 38

On Thu, 27 Mar 2008 09:18:10 +0000
Russell King <rmk+lkml@arm.linux.org.uk> wrote:

> On Thu, Mar 27, 2008 at 10:06:23AM +0100, Haavard Skinnemoen wrote:
> > > +	int		users;
> > 
> > Reference counting, probably need that too.
> > 
> > > +	unsigned long	rate;
> > 
> > This one is redundant. Use getrate() instead.
> 
> ... which means a separate getrate() functions for every clock.  Not really
> practical for PXA.

You can extend the struct, put the rate there and use the same
getrate() function for all the clocks that need to keep track of the
current rate this way.

> > > +	int		delay;
> > 
> > Huh? A delay after enabling the clock? Why can't the enable() hook do
> > that if it's really necessary?
> 
> ... which means a separate enable() function for each clock.  The delay
> there has not a lot to do with the actual register you're frobbing, but
> the resy of the SoC.  So, again, not really practical for PXA.

Same thing, extend the struct and use the same enable() function for
all the clocks that need this delay. We can't add fields to the generic
struct clk for every platform quirk out there...

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/