Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759159AbYC0UZe (ORCPT ); Thu, 27 Mar 2008 16:25:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757635AbYC0UZZ (ORCPT ); Thu, 27 Mar 2008 16:25:25 -0400 Received: from smtp-out0.tiscali.nl ([195.241.79.175]:52858 "EHLO smtp-out0.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757478AbYC0UZZ (ORCPT ); Thu, 27 Mar 2008 16:25:25 -0400 Message-ID: <47EC02A7.5020909@tiscali.nl> Date: Thu, 27 Mar 2008 21:25:11 +0100 From: Roel Kluin <12o3l@tiscali.nl> User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Daniel Walker , Andrew Morton CC: nickpiggin@yahoo.com.au, lkml Subject: [PATCH v2 -mm] likeliness accounting change and cleanup References: <47EAB608.6060204@tiscali.nl> <1206636313.4670.131.camel@localhost.localdomain> In-Reply-To: <1206636313.4670.131.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6245 Lines: 191 Daniel Walker wrote: > It's looks good to me .. You'll have to send it to Andrew to get it > included tho .. > > Daniel Store __builtin_return_address (caller) rather than __func__ in likeliness struct. 'line' and 'type' are combined in 'label' +/- now denotes whether expectation fails in less than 5% of the tests - rather than whether more unexpected than expected were encountered. The function at the displayed filename & line and the caller are not necessarily the same. A few more Likely Profiling Results changes were made. struct seq_operations becomes static, unsigned ints true and false (shadowed) are replaced by pos and neg. Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- This should be applied after the -mm patches: http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/broken-out/profile-likely-unlikely-macros.patch http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/broken-out/profile-likely-unlikely-macros-fix.patch New layout: Likely Profiling Results -------------------------------------------------------------------- [+- ]Type | # True | # False | Function@Filename:Line unlikely | 0| 32082| fget+0xd0/0x1d0@include/asm/arch/atomic_32.h:235 Compiles and runs here. Thanks for previous comments. include/linux/compiler.h | 16 ++++++++-------- lib/likely_prof.c | 45 +++++++++++++++++++++++++-------------------- 2 files changed, 33 insertions(+), 28 deletions(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index d6d9efc..bd31d4c 100644 --- a/include/linux/compiler.h +++ b/include/linux/compiler.h @@ -53,25 +53,25 @@ extern void __chk_io_ptr(const volatile void __iomem *); #if defined(CONFIG_PROFILE_LIKELY) && !(defined(CONFIG_MODULE_UNLOAD) && defined(MODULE)) struct likeliness { - const char *func; - char *file; - int line; - int type; + char *const file; + unsigned long caller; unsigned int count[2]; struct likeliness *next; + unsigned int label; }; -extern int do_check_likely(struct likeliness *likeliness, int exp); +extern int do_check_likely(struct likeliness *likeliness, unsigned int exp); +#define LP_IS_EXPECTED 1 #define LP_UNSEEN 4 +#define LP_LINE_SHIFT 3 #define __check_likely(exp, is_likely) \ ({ \ static struct likeliness likeliness = { \ - .func = __func__, \ .file = __FILE__, \ - .line = __LINE__, \ - .type = is_likely | LP_UNSEEN, \ + .label = __LINE__ << LP_LINE_SHIFT | \ + LP_UNSEEN | is_likely, \ }; \ do_check_likely(&likeliness, !!(exp)); \ }) diff --git a/lib/likely_prof.c b/lib/likely_prof.c index 5c6d91d..c9f5de3 100644 --- a/lib/likely_prof.c +++ b/lib/likely_prof.c @@ -15,34 +15,34 @@ #include #include #include +#include #include #include static struct likeliness *likeliness_head; -int do_check_likely(struct likeliness *likeliness, int ret) +int do_check_likely(struct likeliness *likeliness, unsigned int ret) { static unsigned long likely_lock; - if (ret) - likeliness->count[1]++; - else - likeliness->count[0]++; + likeliness->count[ret]++; - if (likeliness->type & LP_UNSEEN) { + if (likeliness->label & LP_UNSEEN) { /* - * We don't simple use a spinlock because internally to the + * We don't simply use a spinlock because internally to the * spinlock there is a call to unlikely which causes recursion. * We opted for this method because we didn't need a preempt/irq * disable and it was a bit cleaner then using internal __raw * spinlock calls. */ if (!test_and_set_bit(0, &likely_lock)) { - if (likeliness->type & LP_UNSEEN) { - likeliness->type &= (~LP_UNSEEN); + if (likeliness->label & LP_UNSEEN) { + likeliness->label &= (~LP_UNSEEN); likeliness->next = likeliness_head; likeliness_head = likeliness; + likeliness->caller = (unsigned long) + __builtin_return_address(0); } smp_mb__before_clear_bit(); clear_bit(0, &likely_lock); @@ -61,8 +61,8 @@ static void * lp_seq_start(struct seq_file *out, loff_t *pos) seq_printf(out, "Likely Profiling Results\n"); seq_printf(out, " --------------------------------------------" "------------------------\n"); - seq_printf(out, "[+- ] Type | # True | # False | Function:" - "Filename@Line\n"); + seq_printf(out, "[+- ]Type | # True | # False | Function@" + "Filename:Line\n"); out->private = likeliness_head; } @@ -86,18 +86,22 @@ static void *lp_seq_next(struct seq_file *out, void *p, loff_t *pos) static int lp_seq_show(struct seq_file *out, void *p) { struct likeliness *entry = p; - unsigned int true = entry->count[1]; - unsigned int false = entry->count[0]; - - if (!entry->type) { - if (true > false) + unsigned int pos = entry->count[1]; + unsigned int neg = entry->count[0]; + char function[KSYM_SYMBOL_LEN]; + + /* + * Balanced if the suggestion was false in less than 5% of the tests + */ + if (!(entry->label & LP_IS_EXPECTED)) { + if (pos + neg < 20 * pos) seq_printf(out, "+"); else seq_printf(out, " "); seq_printf(out, "unlikely "); } else { - if (true < false) + if (pos + neg < 20 * neg) seq_printf(out, "-"); else seq_printf(out, " "); @@ -105,8 +109,9 @@ static int lp_seq_show(struct seq_file *out, void *p) seq_printf(out, "likely "); } - seq_printf(out, "|%9u|%9u\t%s()@:%s@%d\n", true, false, - entry->func, entry->file, entry->line); + sprint_symbol(function, entry->caller); + seq_printf(out, "|%9u|%9u|\t%s@%s:%u\n", pos, neg, function, + entry->file, entry->label >> LP_LINE_SHIFT); return 0; } @@ -115,7 +120,7 @@ static void lp_seq_stop(struct seq_file *m, void *p) { } -struct seq_operations likely_profiling_ops = { +static struct seq_operations likely_profiling_ops = { .start = lp_seq_start, .next = lp_seq_next, .stop = lp_seq_stop, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/