Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755392AbYC1Bmq (ORCPT ); Thu, 27 Mar 2008 21:42:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753698AbYC1Bme (ORCPT ); Thu, 27 Mar 2008 21:42:34 -0400 Received: from mx1.redhat.com ([66.187.233.31]:54974 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbYC1Bmd (ORCPT ); Thu, 27 Mar 2008 21:42:33 -0400 Date: Thu, 27 Mar 2008 22:42:20 -0300 From: Arnaldo Carvalho de Melo To: David Miller Cc: vda.linux@googlemail.com, ilpo.jarvinen@helsinki.fi, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com Subject: Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot Message-ID: <20080328014220.GK14945@ghostprotocols.net> Mail-Followup-To: Arnaldo Carvalho de Melo , David Miller , vda.linux@googlemail.com, ilpo.jarvinen@helsinki.fi, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1206621486-5408-3-git-send-email-ilpo.jarvinen@helsinki.fi> <1206621486-5408-4-git-send-email-ilpo.jarvinen@helsinki.fi> <200803280036.59311.vda.linux@googlemail.com> <20080327.175212.119805454.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080327.175212.119805454.davem@davemloft.net> X-Url: http://oops.ghostprotocols.net:81/blog User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1070 Lines: 33 Em Thu, Mar 27, 2008 at 05:52:12PM -0700, David Miller escreveu: > From: Denys Vlasenko > Date: Fri, 28 Mar 2008 00:36:59 +0100 > > > Can you add a comment which explains the intent? > > > > +struct sk_buff *dev_alloc_skb(unsigned int length) > > +{ > > + /* There is more code here than it seems: > > + * __dev_alloc_skb is an inline */ > > + return __dev_alloc_skb(length, GFP_ATOMIC); > > +} > > +EXPORT_SYMBOL(dev_alloc_skb); > > I've applied his patch already, if you want this comment > please submit the patch to add it and also please use > the correct formatting of the comment. Which is, of course: /* * There is more code here than it seems: * __def_alloc_skb is an inline */ Ilpo: Keep up the debloating jihad/crusade/campaign/surge/kamppailla! 8-) - arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/