Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755260AbYC1OIS (ORCPT ); Fri, 28 Mar 2008 10:08:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752805AbYC1OIE (ORCPT ); Fri, 28 Mar 2008 10:08:04 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:33931 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbYC1OID (ORCPT ); Fri, 28 Mar 2008 10:08:03 -0400 Date: Fri, 28 Mar 2008 15:06:34 +0100 From: Ingo Molnar To: Gerald Schaefer Cc: Andrew Morton , haveblue@us.ibm.com, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, "David S. Miller" , Tony Luck , Paul Mackerras , Thomas Gleixner , Paul Mundt Subject: Re: [patch 09/10] Hugetlb common code update for System z. Message-ID: <20080328140634.GA29218@elte.hu> References: <20080312173155.703966894@de.ibm.com> <20080312173218.186436562@de.ibm.com> <1205344286.9828.91.camel@nimitz.home.sr71.net> <1205363937.5237.60.camel@localhost.localdomain> <20080312164303.cac9cab5.akpm@linux-foundation.org> <1206713119.5186.52.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1206713119.5186.52.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0001] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 18 * Gerald Schaefer wrote: > include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++ > include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++ > include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++ these seem largely duplicated - shouldnt there be an asm-generic/hugetlb.h instead, which asm/hugetlb.h could include to get default behavior? It would probably reduce the linecount of your patch as well. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/