Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755363AbYC1RW3 (ORCPT ); Fri, 28 Mar 2008 13:22:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753969AbYC1RWV (ORCPT ); Fri, 28 Mar 2008 13:22:21 -0400 Received: from wr-out-0506.google.com ([64.233.184.234]:52234 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753829AbYC1RWU (ORCPT ); Fri, 28 Mar 2008 13:22:20 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=A2nHhcaW0ag6Zpfs60bTUpM1CeJxQw5H/UikFhiuMz2ga/186NS/MFy6mz+kjdkq4eqdBqd3rRfgeu7Fty2q78eiWUoJ0RMxacGNhNZn0ti8JTgvaq2uAvFBFIHBZ3CIpwQ8W50m240k5uzMYKBZUTUS6AyFe+M042ApLAnPfSY= Message-ID: <84144f020803281015s60370d9dpec0913c33004b6c2@mail.gmail.com> Date: Fri, 28 Mar 2008 19:15:02 +0200 From: "Pekka Enberg" To: "Linus Torvalds" Subject: Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24 Cc: "Christoph Lameter" , "Rafael J. Wysocki" , "Pawel Staszewski" , LKML , "Adrian Bunk" , "Andrew Morton" , "Natalie Protasevich" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803272353.51901.rjw@sisk.pl> X-Google-Sender-Auth: 74a3f1bff8e8d3e3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 650 Lines: 15 Hi Christoph, On Fri, Mar 28, 2008 at 6:00 AM, Linus Torvalds wrote: > And the fact is, passing in GFP_ZERO from the SLUB code is a bug > regardless, because it unnecessarily does the dual memset(). We clear GFP_ZERO in new_slab() so the normal kmalloc()/kzalloc() path should be fine but don't do it for kmalloc_large() nor kmalloc_large_node(). Is that the bug here? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/