Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757211AbYC1SF6 (ORCPT ); Fri, 28 Mar 2008 14:05:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755414AbYC1SFj (ORCPT ); Fri, 28 Mar 2008 14:05:39 -0400 Received: from gw.goop.org ([64.81.55.164]:48421 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754884AbYC1SFi (ORCPT ); Fri, 28 Mar 2008 14:05:38 -0400 Message-ID: <47ED3357.7010608@goop.org> Date: Fri, 28 Mar 2008 11:05:11 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Dave Hansen CC: Christoph Lameter , Ingo Molnar , LKML , Rusty Russell , KAMEZAWA Hiroyuki , Yasunori Goto , Andrew Morton Subject: Re: [PATCH 3 of 4] sparsemem: reduce i386 PAE section size References: <47EC574C.10006@goop.org> <47EC8DD0.4090401@goop.org> <1206722599.7883.119.camel@nimitz.home.sr71.net> In-Reply-To: <1206722599.7883.119.camel@nimitz.home.sr71.net> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 26 Dave Hansen wrote: > > Developers should probably learn the tradeoffs before they go start > poking around in code and sending patches. ;) > I don't know any better way of learning the tradeoffs than by poking around and sending patches ;) > BTW, the current 1G sections were picked because all the hardware we > knew of at the time had 512MB dimms that had to be added in pairs. So, > we didn't ever have physical hotplug of less than that. > I guessed it was something like that. Even for my case 1G isn't too bad. It was bad when I was trying to hotplug early and it was having allocation failures in the bootmem allocator, but I think it should be OK now. On the other hand, when you're hotplugging new memory is precisely when you don't want to be allocating lots of new memory... J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/