Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757856AbYC1UB0 (ORCPT ); Fri, 28 Mar 2008 16:01:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753787AbYC1UBS (ORCPT ); Fri, 28 Mar 2008 16:01:18 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:36094 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752991AbYC1UBS (ORCPT ); Fri, 28 Mar 2008 16:01:18 -0400 Message-ID: <47ED4E33.9070203@cs.helsinki.fi> Date: Fri, 28 Mar 2008 21:59:47 +0200 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: Linus Torvalds CC: Christoph Lameter , "Rafael J. Wysocki" , Pawel Staszewski , LKML , Adrian Bunk , Andrew Morton , Natalie Protasevich Subject: Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24 References: <200803272353.51901.rjw@sisk.pl> <84144f020803281015s60370d9dpec0913c33004b6c2@mail.gmail.com> <84144f020803281108o178bf62cp48dcd4f43ec59b74@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 16 Linus Torvalds wrote: > That stupid clearing in new_slab() is totally and utterly irrelevant (in > addition to the fact that it's hard to spot). > > The point was never new_slab(). So why do you even mention it? Because I didn't spot that we're calling kmalloc_large() in the fallback path too. I was referring to the page allocator pass-through kmalloc_large() call that happens before we hit __slab_alloc. My bad, sorry. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/