Date: Sat, 29 Mar 2008 00:36:47 +0200
From: Adrian Bunk <bunk@kernel.org>
To: David Brownell <david-b@pacbell.net>
Cc: Mark Lord <lkml@rtr.ca>, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org, rtc-linux@googlegroups.com,
       David Miller <davem@davemloft.net>
Subject: Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.)
Message-ID: <20080328223647.GM32200@cs181133002.pp.htv.fi>
References: <20080327160700.GB828@suse.de> <200803281445.08025.david-b@pacbell.net> <20080328215913.GL32200@cs181133002.pp.htv.fi> <200803281518.36139.david-b@pacbell.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <200803281518.36139.david-b@pacbell.net>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1534
Lines: 46

On Fri, Mar 28, 2008 at 03:18:35PM -0700, David Brownell wrote:
> On Friday 28 March 2008, Adrian Bunk wrote:
> 
> > > > grep for CONFIG_SUN_MOSTEK_RTC and you'll get the point.
> > > 
> > > Right:  it doesn't mention JS_RTC at all.  Whatever is up
> > > with that stuff, it's broken.
> > 
> > You miss the point, the point is:
> >   drivers/sbus/char/Makefile:obj-$(CONFIG_SUN_MOSTEK_RTC) += rtc.o
> > 
> > Two modules with the same name in one build are not allowed.
> 
> It gets uglier and uglier.  So if that abortion is really
> needed, it'd make more sense to rename the MOSTEK code.
> If that's not fixed, its Kconfig should mention needing
> the JS_RTC thing instead of the "real" legacy rtc.c ...

The Mostek code does not need drivers/char/rtc.c

JS_RTC is only needed for some unusual sparc machines.

> Glad I got rid of my JavaStation ages ago, but I liked
> the idea of having a real builtin coffee cup holder.  :)
>...

I'm not sure, but the JavaStation might actually be one of these unusual 
machines...

> - Dave

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/