Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756804AbYC2Gmv (ORCPT ); Sat, 29 Mar 2008 02:42:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751435AbYC2Gmk (ORCPT ); Sat, 29 Mar 2008 02:42:40 -0400 Received: from gherkin.frus.com ([192.158.254.49]:34612 "EHLO gherkin.frus.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbYC2Gmj (ORCPT ); Sat, 29 Mar 2008 02:42:39 -0400 Subject: Re: [alsa-devel] [regression] 2.6.25-rc4 snd-es18xx broken on Alpha In-Reply-To: <47DFCEDA.2020307@uwo.ca> "from Tyson Whitehead at Mar 18, 2008 10:16:58 am" To: Tyson Whitehead Date: Sat, 29 Mar 2008 01:42:27 -0500 (CDT) CC: Takashi Iwai , ALSA devel , Michael Cree , Krzysztof Helt , Rene Herman , linux-kernel@vger.kernel.org, Ivan Kokshaysky , linux-alpha@vger.kernel.org X-Mailer: ELM [version 2.4ME+ PL82 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Message-Id: <20080329064227.58074DBA2@gherkin.frus.com> From: rct@frus.com (Bob Tracy) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2017 Lines: 52 Ok... I'm back. Replies to the long queue of messages will be sent as I have time to try the various patches. Tyson Whitehead wrote: > Takashi Iwai wrote: > > --- > > > > diff -r 82e6201fc907 sound/isa/es18xx.c > > --- a/sound/isa/es18xx.c Mon Mar 17 14:36:24 2008 +0100 > > +++ b/sound/isa/es18xx.c Mon Mar 17 17:32:59 2008 +0100 > > @@ -765,9 +765,10 @@ static irqreturn_t snd_es18xx_interrupt( > > /* Read Interrupt status */ > > status = snd_es18xx_mixer_read(chip, 0x7f) >> 4; > > } > > -#if 0 > > - else { > > - status = 0; > > + > > +#ifdef CONFIG_ALPHA > > + if (!(status & (AUDIO1_IRQ | AUDIO2_IRQ))) { > > + /* status = 0; */ > > if (inb(chip->port + 0x0C) & 0x01) > > status |= AUDIO1_IRQ; > > if (snd_es18xx_mixer_read(chip, 0x7A) & 0x80) > > @@ -777,7 +778,6 @@ static irqreturn_t snd_es18xx_interrupt( > > status |= HWV_IRQ; > > } > > #endif > > - > > /* Audio 1 & Audio 2 */ > > if (status & AUDIO2_IRQ) { > > if (chip->active & DAC2) > > This looks like it should accomplish the same thing (assuming not bits > get set in status on the initial attempt to read it), without affecting > other platforms and possible the alpha if anyone has a card that just > works for whatever reason. A better patch all around. : ) Unfortunately, this does nothing to fix the ES1888 on my system. Same broken behavior as described previously. I'll try something else in the queue later today after I get some sleep... -- ------------------------------------------------------------------------ Bob Tracy | "I was a beta tester for dirt. They never did rct@frus.com | get all the bugs out." - Steve McGrew on /. ------------------------------------------------------------------------ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/