MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18414.31274.514325.238985@harpo.it.uu.se>
Date: Sat, 29 Mar 2008 18:19:38 +0100
From: Mikael Pettersson <mikpe@it.uu.se>
To: Jacek Luczak <difrost.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Comma at end of enum lists
In-Reply-To: <47EE75A0.8070705@gmail.com>
References: <47EE75A0.8070705@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 937
Lines: 34

Jacek Luczak writes:
 > Hi All,
 > 
 > I've found that in many enum lists, there's a comma at the end, e.g. 
 > (arch/x86/kernel/early_printk.c):
 > 
 > enum {
 >          MAGIC1 = 0xBACCD00A,
 >          MAGIC2 = 0xCA110000,
 >          XOPEN = 5,
 >          XWRITE = 4,
 > };
 > 
 > Just out of curiosity, is there any particular reason here (no word in 
 > CodingStyle about that).

Yes. This idiom allows you to add or remove items without
changing adjacent lines.

In a language with strict a comma-as-separator rule you can
get this benefit by placing the comma before new items rather
than after existing items:

enum {	FOO
	,FIE
	,FUM
};

but luckily C doesn't need this perversion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/