Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbYC2Xw1 (ORCPT ); Sat, 29 Mar 2008 19:52:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751155AbYC2XwT (ORCPT ); Sat, 29 Mar 2008 19:52:19 -0400 Received: from rv-out-0910.google.com ([209.85.198.189]:12358 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbYC2XwS (ORCPT ); Sat, 29 Mar 2008 19:52:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=VdLS/TBVlRybrJotTSQ0ITVRw4s2/8LM+s0gXegzdckUU/wdXzOSm3EKvO4vkgV0q8vcB/KLobDq/xps5mGyoY4zEGnQJC76FcpnoMa7UYZsaBOjbTzvWa8eWNvFJY7meNKKEgeDqDVEeJ3sMCGtW4Ldqj3eRPG6kQWgtIGupWM= Message-ID: <84144f020803291652l13d3de82o424e126655b86119@mail.gmail.com> Date: Sun, 30 Mar 2008 01:52:18 +0200 From: "Pekka Enberg" To: "Linus Torvalds" Subject: Re: 2.6.25-rc7-git2: Reported regressions from 2.6.24 Cc: "Christoph Lameter" , "Rafael J. Wysocki" , "Pawel Staszewski" , LKML , "Adrian Bunk" , "Andrew Morton" , "Natalie Protasevich" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803272353.51901.rjw@sisk.pl> X-Google-Sender-Auth: de69d19777f00492 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 30 Hi, On Sat, 29 Mar 2008, Christoph Lameter wrote: > > Yes it uses its own logic if the object is managed by SLUB but not if the > > object is too big and/or the allocation forwarded to the page allocator > > or for other internal allocations of buffers etc. On Sat, Mar 29, 2008 at 11:29 PM, Linus Torvalds wrote: > Wrong. > > It uses it's own logic for __GFP_ZERO *regardless* of size. Christoph, I think you're overlooking the same thing I was until Linus straightened me out. We're calling kmalloc_large() from __slab_alloc() for the fall-back case which causes a bug fixed by Linus' revert. On Sat, Mar 29, 2008 at 11:29 PM, Linus Torvalds wrote: > You don't have a f*cking clue about this cocde that you're supposed to be > maintaining, do you? Yeah, me too. Fortunately we have you as our upstream maintainer :-). Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/