Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326AbYC3Lnf (ORCPT ); Sun, 30 Mar 2008 07:43:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751486AbYC3Ln2 (ORCPT ); Sun, 30 Mar 2008 07:43:28 -0400 Received: from twinlark.arctic.org ([208.69.40.136]:39847 "EHLO twinlark.arctic.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbYC3Ln1 (ORCPT ); Sun, 30 Mar 2008 07:43:27 -0400 Date: Sun, 30 Mar 2008 04:43:26 -0700 (PDT) From: dean gaudet To: yhlu.kernel@gmail.com cc: Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Andrew Morton , kernel list Subject: Re: [PATCH] x86: pat cpu feature bit setting for known cpus In-Reply-To: <200803242324.35357.yhlu.kernel@gmail.com> Message-ID: References: <200803242324.35357.yhlu.kernel@gmail.com> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 38 On Mon, 24 Mar 2008, Yinghai Lu wrote: > [PATCH] x86: pat cpu feature bit setting for known cpus > > Signed-off-by: Yinghai Lu > > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index eb94460..b186047 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -309,6 +309,19 @@ static void __cpuinit early_get_cap(struct cpuinfo_x86 *c) > > } > > + clear_cpu_cap(c, X86_FEATURE_PAT); > + > + switch (c->x86_vendor) { > + case X86_VENDOR_AMD: > + if (c->x86 >= 0xf && c->x86 <= 0x11) > + set_cpu_cap(c, X86_FEATURE_PAT); just a general comment on things like this... "x->x86 <= 0x11" ensures this file will have to be updated every time a new AMD CPU is released. > + break; > + case X86_VENDOR_INTEL: > + if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >= 15)) note that you didn't limit intel the same way... at least for the numerous core2 processor models. -dean -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/