Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758690AbYFBIiG (ORCPT ); Mon, 2 Jun 2008 04:38:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754093AbYFBIhy (ORCPT ); Mon, 2 Jun 2008 04:37:54 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:56689 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753959AbYFBIhx (ORCPT ); Mon, 2 Jun 2008 04:37:53 -0400 Date: Mon, 2 Jun 2008 09:22:25 +0100 From: Alan Cox To: Jeff Garzik Cc: Pavel Machek , Kristen Carlson Accardi , Theodore Tso , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: ahci: power off unused ports Message-ID: <20080602092225.26db9b5b@core> In-Reply-To: <4843A4A7.3020809@garzik.org> References: <20080508161008.59361de5@appleyard> <20080527030854.GC7515@mit.edu> <20080527143202.4bab5bf0@appleyard> <20080527225926.GE6843@mit.edu> <20080527163251.04054a74@appleyard> <20080531080015.GG5405@ucw.cz> <4842F5A8.9020708@garzik.org> <20080602080440.25fc663c@core> <4843A4A7.3020809@garzik.org> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 18 > The key requirement is per-port control. Ideally via hdparm or another > userspace tool, but kernel command line (module options) or sysfs would > be just fine too. And agreed, the minimal you need is simply 1/0 for > the port's policy. We don't need it per port Jeff, you are being quite silly here. Right now its permanently foo=0 for all ports and nobody has suffered anything too horrible so being able to turn it off for all ports is clearly quite sufficient for the neat future. If someone wants it per port they'll send you a patch later. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/