Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759318AbYFBLTP (ORCPT ); Mon, 2 Jun 2008 07:19:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751587AbYFBLS5 (ORCPT ); Mon, 2 Jun 2008 07:18:57 -0400 Received: from stinky.trash.net ([213.144.137.162]:33154 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbYFBLS4 (ORCPT ); Mon, 2 Jun 2008 07:18:56 -0400 Message-ID: <4843D71A.5090107@trash.net> Date: Mon, 02 Jun 2008 13:18:50 +0200 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.12 (X11/20080405) MIME-Version: 1.0 To: Rami Rosen CC: David Miller , netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-2.6] [NETFILTER] Misc Cleanups. References: <20080601.234549.229050768.davem@davemloft.net> <4843C183.4060008@trash.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 32 Rami Rosen wrote: > Hi, > - Thanks for your comments; I was not aware that this issues occur > in other places too; attached here is another patch, fixing where > applicable in ip6_queue and nfnetlink_queue. > > 1) in net/ipv6/netfilter/ip6_queue.c > - No need to perform data_len = 0 in the switch command, since data_len > is initialized to 0 in the beginning of the > ipq_build_packet_message() method > - We can reach nlmsg_failure only from one place; skb is sure to be NULL > when getting there; since skb is NULL, there is no need to check this fact > and call kfree_skb(). > > 2) in net/netfilter/nfnetlink_queue.c: > - No need to perform data_len = 0 in the switch command, since data_len > is initialized to 0 in the beginning of the > nfqnl_build_packet_message() method > > (Note: here, as opposed to previous patch, nlmsg_failure must check > skb and free it if it is not NULL, so the call to kfree_skb() is > needed , so it is not removed) I've queued this patch and the previous one (without the procfs bits) as one combined patch for 2.6.27, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/