Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760040AbYFBMA3 (ORCPT ); Mon, 2 Jun 2008 08:00:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756439AbYFBMAT (ORCPT ); Mon, 2 Jun 2008 08:00:19 -0400 Received: from styx.suse.cz ([82.119.242.94]:39618 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752657AbYFBMAS (ORCPT ); Mon, 2 Jun 2008 08:00:18 -0400 Date: Mon, 2 Jun 2008 14:00:16 +0200 From: Jan Kara To: Hidehiro Kawai Cc: akpm@linux-foundation.org, sct@redhat.com, adilger@clusterfs.com, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, jack@suse.cz, jbacik@redhat.com, cmm@us.ibm.com, tytso@mit.edu, sugita , Satoshi OSHIMA Subject: Re: [PATCH 3/5] jbd: abort when failed to log metadata buffers Message-ID: <20080602120016.GJ30613@duck.suse.cz> References: <4843CE15.6080506@hitachi.com> <4843CF6A.7090107@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4843CF6A.7090107@hitachi.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 42 On Mon 02-06-08 19:46:02, Hidehiro Kawai wrote: > Subject: [PATCH 3/5] jbd: abort when failed to log metadata buffers > > If we failed to write metadata buffers to the journal space and > succeeded to write the commit record, stale data can be written > back to the filesystem as metadata in the recovery phase. > > To avoid this, when we failed to write out metadata buffers, > abort the journal before writing the commit record. > > Signed-off-by: Hidehiro Kawai Acked-by: Jan Kara Honza > --- > fs/jbd/commit.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6.26-rc4/fs/jbd/commit.c > =================================================================== > --- linux-2.6.26-rc4.orig/fs/jbd/commit.c > +++ linux-2.6.26-rc4/fs/jbd/commit.c > @@ -734,6 +734,9 @@ wait_for_iobuf: > /* AKPM: bforget here */ > } > > + if (err) > + journal_abort(journal, err); > + > jbd_debug(3, "JBD: commit phase 6\n"); > > if (journal_write_commit_record(journal, commit_transaction)) > > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/