Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760356AbYFBMe7 (ORCPT ); Mon, 2 Jun 2008 08:34:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760168AbYFBMem (ORCPT ); Mon, 2 Jun 2008 08:34:42 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:57006 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760212AbYFBMel (ORCPT ); Mon, 2 Jun 2008 08:34:41 -0400 Date: Mon, 02 Jun 2008 21:34:02 +0900 From: Yasunori Goto To: Johannes Weiner Subject: Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core Cc: Andrew Morton , Ingo Molnar , Yinghai Lu , Andi Kleen , linux-kernel@vger.kernel.org, linux-mm@kvack.org In-Reply-To: <20080530194738.789921715@saeurebad.de> References: <20080530194220.286976884@saeurebad.de> <20080530194738.789921715@saeurebad.de> X-Mailer-Plugin: BkASPil for Becky!2 Ver.2.068 Message-Id: <20080602210058.B2E2.E1E9C6FF@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.45 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 28 Hello. > + /* > + * Reserve the area now: > + */ > + for (i = PFN_DOWN(new_start) + merge; i < PFN_UP(new_end); i++) > + if (test_and_set_bit(i, bdata->node_bootmem_map)) > + BUG(); > + > + region = phys_to_virt(bdata->node_boot_start + new_start); > + memset(region, 0, size); > + return region; bdata->last_success doesn't seem to be updated in alloc_bootmem_core(), it is updated in only __free(). Is it intended? If not, it should be updated, I suppose.... Bye. -- Yasunori Goto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/