Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755157AbYFBSPr (ORCPT ); Mon, 2 Jun 2008 14:15:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751795AbYFBSPh (ORCPT ); Mon, 2 Jun 2008 14:15:37 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:44234 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbYFBSPg (ORCPT ); Mon, 2 Jun 2008 14:15:36 -0400 Message-ID: <484438BF.7070303@garzik.org> Date: Mon, 02 Jun 2008 14:15:27 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: kristen.c.accardi@intel.com CC: Mark Lord , Alan Cox , Pavel Machek , Theodore Tso , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: ahci: power off unused ports References: <20080508161008.59361de5@appleyard> <20080527030854.GC7515@mit.edu> <20080527143202.4bab5bf0@appleyard> <20080527225926.GE6843@mit.edu> <20080527163251.04054a74@appleyard> <20080531080015.GG5405@ucw.cz> <4842F5A8.9020708@garzik.org> <20080602080440.25fc663c@core> <4843A4A7.3020809@garzik.org> <4843EF88.2040606@rtr.ca> <48441AA6.8080704@garzik.org> <20080602100019.3d2d2522@appleyard> <484431AB.7010005@garzik.org> <20080602104753.3f24087d@appleyard> In-Reply-To: <20080602104753.3f24087d@appleyard> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 23 Kristen Carlson Accardi wrote: > Here you can see that it would be very easy for another driver > to just add code to set the NO_HOTPLUG flag and then this code > will work for them as well, since we power off the phy using > DET which is specified by SATA. > here's that code: Agreed. The main discussion in this sub-thread is more about user interface. The user interface in this case, a module option, is specific to AHCI. Surely you can see how it is a bit silly to force each driver writer to create the same user interface in each driver, to support a generic concept. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/