Date: Mon, 2 Jun 2008 19:18:32 -0700
From: Arjan van de Ven <arjan@infradead.org>
To: Brice Goglin <brice@myri.com>
Cc: LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org,
       "venkatesh.pallipadi@intel.com" <venkatesh.pallipadi@intel.com>
Subject: Re: howto use ioremap_wc?
Message-ID: <20080602191832.0858eff9@infradead.org>
In-Reply-To: <48441F73.5040005@myri.com>
References: <4841143E.5080003@myri.com>
	<20080531185424.1cd18220@infradead.org>
	<48441F73.5040005@myri.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 983
Lines: 32

On Mon, 02 Jun 2008 18:27:31 +0200
Brice Goglin <brice@myri.com> wrote:


> 
> Agreed, that would be nice!
> 
> >From what we discussed here after your reply, our plan is now to just
> replace
>     ioremap+mtrr_add

which doesn't work as ioremap() may/will force uncached ;)


> with
>     ioremap_wc+mtrr_add
> 
> If mtrr_add() is moved into ioremap_wc(), we'll remove it from
> myri10ge. For now, when PAT is enabled, we may have PAT + MTRR both
> doing WC, but I don't think it can break anything, right?

Both having WC is nicely consistent and the right thing happens...

-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/