Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755969AbYFCEfw (ORCPT ); Tue, 3 Jun 2008 00:35:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751380AbYFCEfn (ORCPT ); Tue, 3 Jun 2008 00:35:43 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:32794 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbYFCEfm (ORCPT ); Tue, 3 Jun 2008 00:35:42 -0400 Date: Tue, 03 Jun 2008 13:35:13 +0900 From: KOSAKI Motohiro To: Eric Dumazet Subject: Re: [PATCH] vmallocinfo: Add NUMA informations Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , Christoph Lameter , Nick Piggin , Hugh Dickins , linux kernel In-Reply-To: <4844BC75.8040705@cosmosbay.com> References: <20080602160548.B6D4.KOSAKI.MOTOHIRO@jp.fujitsu.com> <4844BC75.8040705@cosmosbay.com> Message-Id: <20080603133247.B6E0.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 26 > >> + for (nr = 0; nr < MAX_NUMNODES; nr++) > >> + if (counters[nr]) > >> + seq_printf(m, " N%u=%u", nr, counters[nr]); > > > > for_each_node_state(n, N_HIGH_MEMORY) is better? > > because MAX_NUMNODES has offten very large value. > > > Yes, good idea, thank you. > > I also used nr_node_ids instead of MAX_NUMNODES in this second version : Thank you! looks goot to me. and, my test fouund no bug. Tested-by: KOSAKI Motohiro Cristoph, What do you think? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/