Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163AbYFCEzr (ORCPT ); Tue, 3 Jun 2008 00:55:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751708AbYFCEzi (ORCPT ); Tue, 3 Jun 2008 00:55:38 -0400 Received: from gate.crashing.org ([63.228.1.57]:44763 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbYFCEzh (ORCPT ); Tue, 3 Jun 2008 00:55:37 -0400 Cc: lkml List , "linuxppc-dev@ozlabs.org list" Message-Id: <9B953237-99D2-4593-9A29-242424CDDB29@kernel.crashing.org> From: Kumar Gala To: Sam Ravnborg In-Reply-To: <20080508202200.GA12578@uranus.ravnborg.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v924) Subject: Re: How to link a .o with all modules Date: Mon, 2 Jun 2008 23:55:19 -0500 References: <6C8AB345-2DA0-460D-B7C8-262463247DDE@kernel.crashing.org> <20080504192434.GA23752@uranus.ravnborg.org> <20080505204449.GA9446@uranus.ravnborg.org> <5DD68A6B-45FD-4163-BDF5-356C70A00676@kernel.crashing.org> <20080508202200.GA12578@uranus.ravnborg.org> X-Mailer: Apple Mail (2.924) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1886 Lines: 67 On May 8, 2008, at 3:22 PM, Sam Ravnborg wrote: > On Thu, May 08, 2008 at 09:16:10AM -0500, Kumar Gala wrote: >> >> On May 5, 2008, at 3:44 PM, Sam Ravnborg wrote: >> >>>>> >>>>> >>>>> Let me know if this does address your question. >>>> >>>> The problem is MODPOST complains about undefined symbols: >>>> >>>> MODPOST 24 modules >>>> ERROR: "_restgpr_20_x" [net/key/af_key.ko] undefined! >>>> ERROR: "_restgpr_25_x" [net/key/af_key.ko] undefined! >>>> ERROR: "_restgpr_30_x" [net/key/af_key.ko] undefined! >>> >>> I need a bit more context to try to analyse this. >>> Where did you expect _restgpr_20_x to be defined. >>> If in vmlinux then were they present in the >>> Module.symvers file? >> >> No they aren't there since we I'm not EXPORT_SYMBOL() them. Should I >> also be doing EXPORT_SYMBOL? > > So modpost claim it cannot find the symbols. > >> >>> If in the linked in .o file - could you >>> see the symbols using objdump. >> >> Yes. >> >> readelf -a: >> >> ... >> Symbol table '.symtab' contains 113 entries: >> Num: Value Size Type Bind Vis Ndx Name >> ... >> 5: 00000000 0 FUNC GLOBAL DEFAULT 1 _savegpr_14 >> 6: 00000000 0 FUNC GLOBAL DEFAULT 1 _save32gpr_14 >> ... > > Strange. > > I did not look closer. > But it looks like the linker failed to resolve these symbols > in the final link somehow - despite the symbols are present in > the linked in .o file. > > Can you try to drop me the output of the relocation records for the > finally linked .o file (the one with your .o file linked in). > > objdump -r IIRC Sam, Didn't see any feedback from the relocation records. - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/