Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756817AbYFCLWp (ORCPT ); Tue, 3 Jun 2008 07:22:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753101AbYFCLWg (ORCPT ); Tue, 3 Jun 2008 07:22:36 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:40414 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbYFCLWf (ORCPT ); Tue, 3 Jun 2008 07:22:35 -0400 Date: Tue, 3 Jun 2008 12:22:21 +0100 From: Al Viro To: Miklos Szeredi Cc: mtk.manpages@googlemail.com, drepper@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-man@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] utimensat() non-conformances and fixes [v3] Message-ID: <20080603112221.GW28946@ZenIV.linux.org.uk> References: <482D4665.4050401@gmail.com> <48401E7E.9090304@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 24 On Tue, Jun 03, 2008 at 01:13:00PM +0200, Miklos Szeredi wrote: > > > I'm not sure of the correct way to get the required nameidata (to do a > > > vfs_permission() call) from the file descriptor. Can you give me a > > > tip there? > > > > Could you point me at the right way of doing this? > > You don't need nameidata for this at all. Just call permission() with > a NULL nameidata. > > Ugly API? Yes, will be cleaned up if we manage to find some common > ground with the VFS maintainers. As soon as I'm done with sysctls... FWIW, I very much doubt that you are right wrt required permissions, though. AFAICS, intent here is "if you can write to file, you can touch the timestamps anyway" and having descriptor opened for write gives that, current permissions be damned. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/