Date: Tue, 3 Jun 2008 05:17:21 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Nadia.Derbey@bull.net
Cc: akpm@linux-foundation.org, manfred@colorfullife.com,
       lnxninja@linux.vnet.ibm.com, efault@gmx.de,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm1] Remove useless calls to INIT_RCU_HEAD in the idr code (was Scalability requirements for sysv ipc - v3)
Message-ID: <20080603121721.GA13488@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <20080603065633.480505000@bull.net> <20080603065712.322118000@bull.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080603065712.322118000@bull.net>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1710
Lines: 60

On Tue, Jun 03, 2008 at 08:56:34AM +0200, Nadia.Derbey@bull.net wrote:
> Since I didn't get any answer yesterday, (see http://lkml.org/lkml/2008/6/2/20)
> here's the patch after Paul's review.
> 
> 
> Regards,
> Nadia
> 
> [ PATCH 01/01 ]
> 
> This is a trivial patch that removes unneeded calls to INIT_RCU_HEAD() in the
> idr api code.
> 
> This patch applies to 2.6.26-rc2-mm1.

Looks good to me!

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net>
> 
> ---
>  lib/idr.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> Index: linux-2.6.26-rc2-mm1/lib/idr.c
> ===================================================================
> --- linux-2.6.26-rc2-mm1.orig/lib/idr.c	2008-05-29 13:09:01.000000000 +0200
> +++ linux-2.6.26-rc2-mm1/lib/idr.c	2008-06-02 09:32:46.000000000 +0200
> @@ -185,7 +185,6 @@ static int sub_alloc(struct idr *idp, in
>  			new = get_from_free_list(idp);
>  			if (!new)
>  				return -1;
> -			INIT_RCU_HEAD(&new->rcu_head);
>  			rcu_assign_pointer(p->ary[m], new);
>  			p->count++;
>  		}
> @@ -211,7 +210,6 @@ build_up:
>  	if (unlikely(!p)) {
>  		if (!(p = get_from_free_list(idp)))
>  			return -1;
> -		INIT_RCU_HEAD(&p->rcu_head);
>  		layers = 1;
>  	}
>  	/*
> @@ -239,7 +237,6 @@ build_up:
>  		}
>  		new->ary[0] = p;
>  		new->count = 1;
> -		INIT_RCU_HEAD(&new->rcu_head);
>  		if (p->bitmap == IDR_FULL)
>  			__set_bit(0, &new->bitmap);
>  		p = new;
> 
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/