Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754725AbYFCRws (ORCPT ); Tue, 3 Jun 2008 13:52:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752427AbYFCRwj (ORCPT ); Tue, 3 Jun 2008 13:52:39 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:60289 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbYFCRwi (ORCPT ); Tue, 3 Jun 2008 13:52:38 -0400 X-Sasl-enc: t7NfZ3ZFy5l9XAybMKJsJTiOUF4RBYqyRqfGvGIfheUK 1212515557 Subject: Re: Linux 2.6.26-rc4 From: Ian Kent To: Al Viro Cc: Linus Torvalds , Miklos Szeredi , jesper@krogh.cc, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org In-Reply-To: <20080603175053.GF28946@ZenIV.linux.org.uk> References: <20080603105258.GV28946@ZenIV.linux.org.uk> <1212499623.3025.46.camel@raven.themaw.net> <1212509263.3025.66.camel@raven.themaw.net> <20080603164102.GB28946@ZenIV.linux.org.uk> <20080603165042.GC28946@ZenIV.linux.org.uk> <1212514104.3025.110.camel@raven.themaw.net> <20080603174125.GE28946@ZenIV.linux.org.uk> <1212514893.3025.123.camel@raven.themaw.net> <20080603175053.GF28946@ZenIV.linux.org.uk> Content-Type: text/plain Date: Wed, 04 Jun 2008 01:49:22 +0800 Message-Id: <1212515363.3025.125.camel@raven.themaw.net> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-4.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 19 On Tue, 2008-06-03 at 18:50 +0100, Al Viro wrote: > On Wed, Jun 04, 2008 at 01:41:32AM +0800, Ian Kent wrote: > > > OK, I'll need to look at vfs_readdir(). > > I thought vfs_readdir() would take the containing directory mutex as > > does ->lookup(). > > vfs_readdir() takes i_mutex on directory it reads. I.e. on the victim > in this case. lookup has i_mutex on directory it does lookup in, i.e. > root in this case... Hahaha, yes, I'll need to go back and re-read that bit of code, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/