Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757462AbYFCUZn (ORCPT ); Tue, 3 Jun 2008 16:25:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752125AbYFCUZ2 (ORCPT ); Tue, 3 Jun 2008 16:25:28 -0400 Received: from smtpq2.groni1.gr.home.nl ([213.51.130.201]:46392 "EHLO smtpq2.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbYFCUZ1 (ORCPT ); Tue, 3 Jun 2008 16:25:27 -0400 Message-ID: <4845A8AE.30009@keyaccess.nl> Date: Tue, 03 Jun 2008 22:25:18 +0200 From: Rene Herman User-Agent: Thunderbird 2.0.0.14 (X11/20080421) MIME-Version: 1.0 To: Bjorn Helgaas CC: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Belay , Adam M Belay , Li Shaohua , Matthieu Castet , Thomas Renninger , Jaroslav Kysela , Andrew Morton , Takashi Iwai Subject: Re: [patch 14/15] PNP: support optional IRQ resources References: <20080530224853.976744229@ldl.fc.hp.com> <20080530224934.156287156@ldl.fc.hp.com> <48458141.9020409@keyaccess.nl> <200806031421.00767.bjorn.helgaas@hp.com> In-Reply-To: <200806031421.00767.bjorn.helgaas@hp.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 35 On 03-06-08 22:20, Bjorn Helgaas wrote: > On Tuesday 03 June 2008 11:37:05 am Rene Herman wrote: >>> Index: work10/include/linux/ioport.h >>> =================================================================== >>> --- work10.orig/include/linux/ioport.h 2008-05-20 13:34:58.000000000 -0600 >>> +++ work10/include/linux/ioport.h 2008-05-20 13:39:21.000000000 -0600 >>> @@ -59,6 +59,7 @@ struct resource_list { >>> #define IORESOURCE_IRQ_HIGHLEVEL (1<<2) >>> #define IORESOURCE_IRQ_LOWLEVEL (1<<3) >>> #define IORESOURCE_IRQ_SHAREABLE (1<<4) >>> +#define IORESOURCE_IRQ_OPTIONAL (1<<5) >>> >>> /* ISA PnP DMA specific bits (IORESOURCE_BITS) */ >>> #define IORESOURCE_DMA_TYPE_MASK (3<<0) >> Andrew scooped up a patch from a previous reaction of mine that deleted >> the "ISA " from these comments. I tend to use comments as a great way of >> avoiding actually reading code (I'm silly like that) and so as to be >> burned a _bit_ less by it, I think it's good if they're accurate. In >> this case for example, one might be tempted to assume these bits were >> specific to drivers/pnp/isapnp. > > Yes, I see that's pnpacpi-fix-irq-flag-decoding-comment-fix.patch > in mmotm. How about if I incorporate that in my series (the one > Andrew hasn't yet picked up), since your patch will otherwise > conflict with it? Yep, that would be good. Rene. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/