Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755177AbYFDCyc (ORCPT ); Tue, 3 Jun 2008 22:54:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752231AbYFDCyT (ORCPT ); Tue, 3 Jun 2008 22:54:19 -0400 Received: from linode.ducksong.com ([64.22.125.164]:57545 "EHLO linode.ducksong.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbYFDCyS (ORCPT ); Tue, 3 Jun 2008 22:54:18 -0400 Subject: Re: [fixed] [patch] Re: [bug] stuck localhost TCP connections, v2.6.26-rc3+ From: Patrick McManus To: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= Cc: David Miller , mingo@elte.hu, peterz@infradead.org, LKML , Netdev , rjw@sisk.pl, Andrew Morton , johnpol@2ka.mipt.ru In-Reply-To: References: <20080603094057.GA29480@elte.hu> <20080603.150344.145518113.davem@davemloft.net> Content-Type: text/plain; charset=UTF-8 Date: Tue, 03 Jun 2008 22:54:52 -0400 Message-Id: <1212548093.12617.0.camel@tng> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 29 On Wed, 2008-06-04 at 02:22 +0300, Ilpo Järvinen wrote: == > -- > [PATCH] tcp DEFER_ACCEPT: fix racy access to listen_sk > > It seems that replacement of DA code also moved parts outside > of appropriate locking. The Ingo's problem seems to come from > the fact that two flows could now race in > (inet_csk_)reqsk_queue_add corrupting the queue. ...This can > leave dangling socks around which won't resolve themselves > without stimuli from outside (e.g., external RST would help > I think). Ilpo, has anyone told you today that you rock? Well allow me - you rock. > do_rcv() clearly has the listening socket locked in the non-DA case, and in the DA case it is the 'child' ESTABLISHED socket that is locked - leaving the accept queue unprotected. So simple. -Pat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/