Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757774AbYFDG0x (ORCPT ); Wed, 4 Jun 2008 02:26:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751306AbYFDG0n (ORCPT ); Wed, 4 Jun 2008 02:26:43 -0400 Received: from rv-out-0506.google.com ([209.85.198.225]:29468 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755035AbYFDG0m (ORCPT ); Wed, 4 Jun 2008 02:26:42 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qqHvdXrNedO1zF6VcGwAublk/XbfPo7VbF6eMpvZaEjjneE4OMnmNCIzj3eawluFaEPJjS1V+LSKX2dhrsLBPLvUGoDouyUmmxMUFtyBbaMOKVC00xVWgdeqyeU/U8gTPrbonh0Px7qCsM1paxrFrBc8bDu6NksJAT/eotL0PVk= Message-ID: <86802c440806032326x3ddf81ebw9592aae8d7f97092@mail.gmail.com> Date: Tue, 3 Jun 2008 23:26:40 -0700 From: "Yinghai Lu" To: "Glauber Costa" Subject: Re: [PATCH] Make x86 latest boot with non-discontig boxes Cc: "Glauber Costa" , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu In-Reply-To: <5d6222a80806032220ta8d3847l3ce0c0a8df135446@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1212552507-15134-1-git-send-email-gcosta@redhat.com> <86802c440806032151l5faedf22xe0107d4c99c55c21@mail.gmail.com> <5d6222a80806032220ta8d3847l3ce0c0a8df135446@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2156 Lines: 62 On Tue, Jun 3, 2008 at 10:20 PM, Glauber Costa wrote: > On Wed, Jun 4, 2008 at 1:51 AM, Yinghai Lu wrote: >> On Tue, Jun 3, 2008 at 9:08 PM, Glauber Costa wrote: >>> Commit 0596152388e234efebce464355186ad9e16c8cb6 >>> broke my box, since it removes completely the call to >>> memory_present() at e820 setup. >>> >>> It seems to be really not needed with discontig memory, >>> but with flat and sparse, I get an early crash. The proposed patch >>> moves the call memory_present() to setup_memory, the one >>> present in setup_32.c. >>> >>> Signed-off-by: Glauber Costa >>> CC: Yinghai Lu >>> --- >>> arch/x86/kernel/setup_32.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c >>> index 2901042..841eb2f 100644 >>> --- a/arch/x86/kernel/setup_32.c >>> +++ b/arch/x86/kernel/setup_32.c >>> @@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void) >>> #ifdef CONFIG_FLATMEM >>> max_mapnr = num_physpages; >>> #endif >>> + memory_present(0, 0, max_pfn); >>> + >>> printk(KERN_NOTICE "%ldMB LOWMEM available.\n", >>> pages_to_mb(max_low_pfn)); >>> >>> -- >> thanks >> >> http://lkml.org/lkml/2008/6/3/229 >> [PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix >> >> already address that. >> >> YH > > Great. > > I guess it was not on the tree yet, then. > yes today sent out several [PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix [PATCH] x86: early check if one system is numaq v2 [PATCH] x86: remove all active before register them again after trimming - 64bit [PATCH] x86: numa32 make sure get kva space [PATCH] x86: move e820_register_active to e820.c [PATCH] x86: 32 bit use e820_register_active_regions YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/