Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758370AbYFDHb7 (ORCPT ); Wed, 4 Jun 2008 03:31:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751990AbYFDHbv (ORCPT ); Wed, 4 Jun 2008 03:31:51 -0400 Received: from rv-out-0506.google.com ([209.85.198.227]:17404 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbYFDHbv (ORCPT ); Wed, 4 Jun 2008 03:31:51 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lu6d3KfofOzFpVpfUN96yOa80SgHDgXr1q50QAmeq18xJEB1nE/QJTssgohViu/WrR5dvi/YiWUuAvoCy4VrkotEDymbETBg8+UA/EsULL/GgENwVk30Xayy16jF1mz+672IB0dezp7MCjx+nheTA5z+hTh7Ar447PKIUzXbbTE= Message-ID: Date: Wed, 4 Jun 2008 09:31:50 +0200 From: "Andrew Victor" To: "Andrew Morton" Subject: Re: AT91SAM9/CAP9 watchdog driver Cc: wim@iguana.be, linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org In-Reply-To: <20080603142316.c53b32b2.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080603142316.c53b32b2.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 19 hi Andrew, >> + return 0; > > That looks like the wrong return value? Since the watchdog registers are Write-Once, if the user does not specify a "wdt_timeout" parameter we'd still like the driver to load even if it's not enabled. The user can then always use ioctl(WDIOC_SETTIMEOUT:) to set the timeout later. Regards, Andrew Victor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/