Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760208AbYFDLww (ORCPT ); Wed, 4 Jun 2008 07:52:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753718AbYFDLwp (ORCPT ); Wed, 4 Jun 2008 07:52:45 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:40995 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751163AbYFDLwo (ORCPT ); Wed, 4 Jun 2008 07:52:44 -0400 Date: Wed, 4 Jun 2008 12:36:42 +0100 From: Alan Cox To: "Andrew Victor" Cc: "Andrew Morton" , wim@iguana.be, linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: AT91SAM9/CAP9 watchdog driver Message-ID: <20080604123642.51449a04@core> In-Reply-To: References: <20080603142316.c53b32b2.akpm@linux-foundation.org> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 20 On Wed, 4 Jun 2008 09:31:50 +0200 "Andrew Victor" wrote: > hi Andrew, > > >> + return 0; > > > > That looks like the wrong return value? > > Since the watchdog registers are Write-Once, if the user does not > specify a "wdt_timeout" parameter we'd still like the driver to load > even if it's not enabled. Surely you can avoid doing the register writes until after you check the validity of arguments ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/