Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760275AbYFDMdo (ORCPT ); Wed, 4 Jun 2008 08:33:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753228AbYFDMdg (ORCPT ); Wed, 4 Jun 2008 08:33:36 -0400 Received: from rcpt-expgw.biglobe.ne.jp ([133.205.19.66]:37974 "EHLO rcpt-expgw.biglobe.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbYFDMdf (ORCPT ); Wed, 4 Jun 2008 08:33:35 -0400 X-Biglobe-Sender: Date: Wed, 4 Jun 2008 21:32:35 +0900 From: Daisuke Nishimura To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , LKML , "balbir@linux.vnet.ibm.com" , "menage@google.com" , "xemul@openvz.org" , "yamamoto@valinux.co.jp" Subject: Re: [RFC][PATCH 2/2] memcg: hardwall hierarhcy for memcg Message-Id: <20080604213235.defb1d01.d-nishimura@mtf.biglobe.ne.jp> In-Reply-To: <20080604140329.8db1b67e.kamezawa.hiroyu@jp.fujitsu.com> References: <20080604135815.498eaf82.kamezawa.hiroyu@jp.fujitsu.com> <20080604140329.8db1b67e.kamezawa.hiroyu@jp.fujitsu.com> Reply-To: nishimura@mxp.nes.nec.co.jp X-Mailer: Sylpheed 2.3.1 (GTK+ 2.10.14; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 28 Hi. > @@ -848,6 +937,8 @@ static int mem_cgroup_force_empty(struct > if (mem_cgroup_subsys.disabled) > return 0; > > + memcg_shrink_all(mem); > + > css_get(&mem->css); > /* > * page reclaim code (kswapd etc..) will move pages between Shouldn't it be called after verifying there remains no task in this group? If called via mem_cgroup_pre_destroy, it has been verified that there remains no task already, but if called via mem_force_empty_wrte, there may remain some tasks and this means many and many pages are swaped out, doesn't it? Thanks, Daisuke Nishimura. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/