Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760885AbYFDRUS (ORCPT ); Wed, 4 Jun 2008 13:20:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753038AbYFDRUE (ORCPT ); Wed, 4 Jun 2008 13:20:04 -0400 Received: from nwd2mail11.analog.com ([137.71.25.57]:55420 "EHLO nwd2mail11.analog.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753079AbYFDRUD convert rfc822-to-8bit (ORCPT ); Wed, 4 Jun 2008 13:20:03 -0400 X-IronPort-AV: E=Sophos;i="4.27,590,1204520400"; d="scan'208";a="54636789" X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH 1/1] mtd m25p80: fix bug - ATmel spi flash fails to becopied to Date: Wed, 4 Jun 2008 18:20:52 +0100 Message-ID: <8A42379416420646B9BFAC9682273B6D01FB8036@limkexm3.ad.analog.com> In-Reply-To: <1212598723.32207.130.camel@pmac.infradead.org> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 1/1] mtd m25p80: fix bug - ATmel spi flash fails to becopied to Thread-Index: AcjGZEpWE+wBxq7DRwG9Ml7v/U2dFQAArqxA References: <1211021526-24076-1-git-send-email-cooloney@kernel.org> <8A42379416420646B9BFAC9682273B6D0183AE38@limkexm3.ad.analog.com> <386072610805190253g42d47d81w794b3c14c15aa890@mail.gmail.com> <1212598723.32207.130.camel@pmac.infradead.org> From: "Hennerich, Michael" To: "David Woodhouse" , "Bryan Wu" Cc: "Hennerich, Michael" , , , X-OriginalArrivalTime: 04 Jun 2008 17:19:59.0674 (UTC) FILETIME=[3798A1A0:01C8C667] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 61 David, Bryan sent an incremental update patch, some time ago. See below ... Regards, Michael From: Michael Hennerich remove duplicate code. Signed-off-by: Michael Hennerich Signed-off-by: Bryan Wu --- drivers/mtd/devices/m25p80.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index b10649b..7f89b54 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -122,8 +122,6 @@ static int write_sr(struct m25p *flash, u8 val) flash->command[0] = OPCODE_WRSR; flash->command[1] = val; - spi_write(flash->spi, flash->command, 2); - return spi_write(flash->spi, flash->command, 2); } -- 1.5.5 >-----Original Message----- >From: David Woodhouse [mailto:dwmw2@infradead.org] >Sent: Mittwoch, 4. Juni 2008 18:59 >To: Bryan Wu >Cc: Hennerich, Michael; linux-mtd@lists.infradead.org; linux- >kernel@vger.kernel.org; mike@steroidmicros.com >Subject: Re: [PATCH 1/1] mtd m25p80: fix bug - ATmel spi flash fails to >becopied to > >On Mon, 2008-05-19 at 17:53 +0800, Bryan Wu wrote: >> >> > >> > I just noticed that write_sr contains a duplicated spi_write. >> > Bryan sends out a new patch. >> > >> >> >> No problem, it is my fault. I should review the patch carefully. > >Was there a new patch coming? > >-- >dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/