Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762203AbYFDTCu (ORCPT ); Wed, 4 Jun 2008 15:02:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760060AbYFDTCk (ORCPT ); Wed, 4 Jun 2008 15:02:40 -0400 Received: from hs-out-0708.google.com ([64.233.178.251]:23029 "EHLO hs-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759534AbYFDTCh (ORCPT ); Wed, 4 Jun 2008 15:02:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=px+e0YtnK4dPzYU1U/m8+uCP3YZ5Hep7oDQPmRPcECbR0x6MvvsuLdkEOU3TAg5tr2 goMOZtug0wOzsITUMKmTjBO1dswyhn8OFckvY3QQaNPAGQxRFK6KMu5QFGANON/Drv3r RMnKhcPnXGNTMhyyLL8ViGiWqL7elufy8ZY7g= Message-ID: Date: Wed, 4 Jun 2008 21:02:30 +0200 From: "Andrew Victor" To: "Alan Cox" Subject: Re: AT91SAM9/CAP9 watchdog driver Cc: "Andrew Morton" , wim@iguana.be, linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org In-Reply-To: <20080604192458.02f76022@core> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080603142316.c53b32b2.akpm@linux-foundation.org> <20080604123642.51449a04@core> <20080604192458.02f76022@core> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 26 hi Alan , > Every other watchdog behaves as follows > > - If you specify a bogus value it doesn't load > - If you specify no value you get a valid default > - If you specify a valid value you get that > > I don't believe yours should be different. I don't think any other in-kernel watchdog driver has to deal with write-once hardware. On these processors once the watchdog register is programmed, it cannot be disabled or re-programmed. If the above behaviour is required, then we might aswell remove the ioctl(WDIOC_SETTIMEOUT) interface for this driver since if the user wants anything other than the default timeout they would need to pass it via the kernel command-line or module parameters. Regards, Andrew Victor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/