Date: Wed, 4 Jun 2008 22:48:38 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Alex Chiang <achiang@hp.com>
Cc: jbarnes@virtuousgeek.org,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       kaneshige.kenji@jp.fujitsu.com, Matthew Wilcox <matthew@wil.cx>,
       kristen.c.accardi@intel.com, greg@kroah.com, lenb@kernel.org,
       pbadari@us.ibm.com, linux-pci@vger.kernel.org,
       pcihpd-discuss@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject: Export kobject_rename for pci_hotplug_core
Message-Id: <20080604224838.6b556a51.akpm@linux-foundation.org>
In-Reply-To: <20080604201606.GE379@ldl.fc.hp.com>
References: <20080604200829.GC379@ldl.fc.hp.com>
	<20080604201606.GE379@ldl.fc.hp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1380
Lines: 40

On Wed, 4 Jun 2008 14:16:06 -0600 Alex Chiang <achiang@hp.com> wrote:

> From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
> 
> Export kobject_rename() to fix the following link error.  This happens when
> pci_hotplug_core driver is compiled as a kernel module.
> 
> ERROR: "kobject_rename" [drivers/pci/hotplug/pci_hotplug.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> make: *** Waiting for unfinished jobs....
> 
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
> Acked-by: Alex Chiang <achiang@hp.com>
> Cc: Greg KH <greg@kroah.com>
> Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Alex Chiang <achiang@hp.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>  lib/kobject.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 718e510..dcade05 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -439,6 +439,7 @@ out:
>  
>  	return error;
>  }
> +EXPORT_SYMBOL_GPL(kobject_rename);

Shouldn't this go straight into 2.6.26?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/