Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757972AbYFEMKh (ORCPT ); Thu, 5 Jun 2008 08:10:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756177AbYFEMK3 (ORCPT ); Thu, 5 Jun 2008 08:10:29 -0400 Received: from extu-mxob-1.symantec.com ([216.10.194.28]:37176 "EHLO extu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753462AbYFEMK2 (ORCPT ); Thu, 5 Jun 2008 08:10:28 -0400 Date: Thu, 5 Jun 2008 13:09:49 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@blonde.site To: Olaf Hering cc: Alan Cox , Jeff Garzik , Linus Torvalds , linuxppc-dev@ozlabs.org, Linux Kernel Mailing List Subject: Re: Linux 2.6.26-rc5 (G5 SATA broken) In-Reply-To: <20080605112436.GA4533@aepfle.de> Message-ID: References: <20080605112436.GA4533@aepfle.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1895 Lines: 50 On Thu, 5 Jun 2008, Olaf Hering wrote: > On Wed, Jun 04, Linus Torvalds wrote: > > > Another week, another batch of mostly pretty small fixes. Hopefully the > > regression list is shrinking, and we've fixed at least a couple of the > > oopses on Arjan's list. > > SATA on a dualcore G5 is broken, it happend between > c3b25b32e8bef526cca748e1ba023c6bdd705a99..53c8ba95402be65d412a806cda3430f0e72cd107 > > irq 18: nobody cared (try booting with the "irqpoll" option) > Disabling IRQ #18 > > ctrl alt del on the USB keyboard does not trigger a reboot. > Sometimes the cursor stops blinking, sometimes just nothing happens > after ctrl alt del. > > Does 53c8ba95402be65d412a806cda3430f0e72cd107 work for others on G5? I've been bisecting that on Quad G5 (sata_svw): irq 18: nobody cared ..., then later endless ata1.00: exception..., blah blah, ata1: EH complete. It comes down to: commit a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2 Author: Alan Cox Date: Thu May 29 22:10:58 2008 +0100 libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl And the patch I'm finding successful is below: I won't sign it off, for all I know it's reverting part of what Alan is trying to achieve; but I expect it'll help towards the right fix. Hugh --- 2.6.26-rc5/drivers/ata/libata-sff.c 2008-06-05 07:18:07.000000000 +0100 +++ linux/drivers/ata/libata-sff.c 2008-06-05 12:42:39.000000000 +0100 @@ -278,7 +278,7 @@ static u8 ata_sff_irq_status(struct ata_ return status; } /* Clear INTRQ latch */ - status = ata_sff_check_status(ap); + status = ap->ops->sff_check_status(ap); return status; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/