Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759228AbYFERgV (ORCPT ); Thu, 5 Jun 2008 13:36:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750764AbYFERgO (ORCPT ); Thu, 5 Jun 2008 13:36:14 -0400 Received: from wx-out-0506.google.com ([66.249.82.231]:63982 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbYFERgN (ORCPT ); Thu, 5 Jun 2008 13:36:13 -0400 Message-ID: Date: Thu, 5 Jun 2008 11:36:09 -0600 From: "Grant Likely" To: avorontsov@ru.mvista.com Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver Cc: "Pierre Ossman" , "David Brownell" , "Jochen Friedrich" , "Segher Boessenkool" , "Gary Jennejohn" , "Guennadi Liakhovetski" , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <20080605172723.GA14514@polina.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080605161624.GA517@polina.dev.rtsoft.ru> <20080605172723.GA14514@polina.dev.rtsoft.ru> X-Google-Sender-Auth: aeec68df67846104 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2429 Lines: 60 On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov wrote: > On Thu, Jun 05, 2008 at 10:45:17AM -0600, Grant Likely wrote: >> On Thu, Jun 5, 2008 at 10:16 AM, Anton Vorontsov >> wrote: >> > Here is v3. I'm out of ideas if you won't like it. :-) >> > >> > v3: >> > - Now these bindings are using bus notifiers chain, thus we adhere to the >> > spi bus. >> > >> > By the way, this scheme (IMO) looks good for I2C devices which needs >> > platform_data extracted from the device tree too (Cc'ing Jochen). >> > >> > - Plus changed the OF bindings themselves, implemented voltage-range >> > property. (Pierre, please take a look at vddrange_to_ocrmask(). I >> > wonder if you would like this in the MMC core instead, with a kernel >> > doc, of course.) >> > >> > v2: >> > - Bindings were adhered to the MMC_SPI driver. Withdrawn by Pierre Ossman. >> >> Personally I think your v2 was better, and if I'm interpreting >> Pierre's comments correctly I think his main point is that instead of >> using the 'stock' probe/remove hooks for the spi mmc driver, the >> driver should be mildly reworked to provide a common block of code >> that can be used by both the OF and non-OF versions of the >> probe/remove routines. I also think that is the way to go. > > Well, I mentioned the usb_add_hcd()-alike approach for the mmc_spi > host... The absence of enthusiasm I equaled to "no". > > Heh. I'm allergic to USB HCD code; I was probably having convulsions under my desk. > p.s. > Btw, you forgot another downside of v2 approach: struct spi_driver > duplication... Not sure if everyone will be happy about it. > > Though, v2 is only version where we can make modular OF_MMC_SPI. I think we've got our wires crossed. I'm not referring to the option of an of_mmc_spi driver registering an mmc_spi device (which can then be probed by the mmc_spi_driver). I'm referring to refactoring the probe/remove code so that common stuff is callable by both the mmc_spi and of_mmc_spi drivers without the oddity of the of_mmc_spi probe hook calling the mmc_spi probe hook. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/