Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760732AbYFETOT (ORCPT ); Thu, 5 Jun 2008 15:14:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751763AbYFETOJ (ORCPT ); Thu, 5 Jun 2008 15:14:09 -0400 Received: from mx1.redhat.com ([66.187.233.31]:52565 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbYFETOI (ORCPT ); Thu, 5 Jun 2008 15:14:08 -0400 From: Jarod Wilson Organization: Red Hat, Inc. To: linux1394-devel@lists.sourceforge.net Subject: Re: [PATCH] firewire: fw-ohci: write selfIDBufferPtr before LinkControl.rcvSelfID Date: Thu, 5 Jun 2008 15:13:27 -0400 User-Agent: KMail/1.9.9 Cc: Stefan Richter , linux-kernel@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806051513.27568.jwilson@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 23 On Thursday 05 June 2008 02:50:53 pm Stefan Richter wrote: > OHCI 1.1 clause 5.10 requires that selfIDBufferPtr is valid when a 1 is > written into LinkControl.rcvSelfID. > > This driver bug has so far not been known to cause harm because most > chips obviously accept a later selfIDBufferPtr write. > > Signed-off-by: Stefan Richter I vaguely recall discussing this one before. Doesn't seem to have caused any problems in practice, but yeah, should go ahead and be more spec compliant here. Signed-off-by: Jarod Wilson -- Jarod Wilson jwilson@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/