Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756693AbYFFHRy (ORCPT ); Fri, 6 Jun 2008 03:17:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756534AbYFFHRc (ORCPT ); Fri, 6 Jun 2008 03:17:32 -0400 Received: from fnoeppeil48.netpark.at ([217.175.205.176]:56125 "EHLO roarinelk.homelinux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755904AbYFFHRb (ORCPT ); Fri, 6 Jun 2008 03:17:31 -0400 Date: Fri, 6 Jun 2008 09:17:29 +0200 From: Manuel Lauss To: Pierre Ossman Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, sshtylyov@ru.mvista.com Subject: Re: [PATCH 8/9] au1xmmc: abort requests early if no card is present Message-ID: <20080606071729.GB16498@roarinelk.homelinux.net> References: <20080519080339.GA21985@roarinelk.homelinux.net> <20080519080804.GI21985@roarinelk.homelinux.net> <20080605230552.68c14b2d@mjolnir.drzeus.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080605230552.68c14b2d@mjolnir.drzeus.cx> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1649 Lines: 49 Hi Pierre, On Thu, Jun 05, 2008 at 11:05:52PM +0200, Pierre Ossman wrote: > On Mon, 19 May 2008 10:08:04 +0200 > Manuel Lauss wrote: > > > From ec41439903048bf98e301dbd03426c63156ebc0e Mon Sep 17 00:00:00 2001 > > From: Manuel Lauss > > Date: Sun, 18 May 2008 15:52:43 +0200 > > Subject: [PATCH] au1xmmc: abort requests early if no card is present > > > > Don't process a request if no card is present. > > > > Signed-off-by: Manuel Lauss > > --- > > drivers/mmc/host/au1xmmc.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c > > index be09a14..0b30582 100644 > > --- a/drivers/mmc/host/au1xmmc.c > > +++ b/drivers/mmc/host/au1xmmc.c > > @@ -689,6 +689,13 @@ static void au1xmmc_request(struct mmc_host *mmc, struct mmc_request *mrq) > > host->mrq = mrq; > > host->status = HOST_S_CMD; > > > > + /* fail request immediately if no card is present */ > > + if (0 == au1xmmc_card_inserted(host)) { > > + mrq->cmd->error = -ETIMEDOUT; > > + au1xmmc_finish_request(host); > > + return; > > + } > > + > > if (mrq->data) { > > FLUSH_FIFO(host); > > ret = au1xmmc_prepare_data(host, mrq->data); > > You should use -ENOMEDIUM for this case. Didn't know it existed, consider it changed. Thanks! Manuel Lauss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/