Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762621AbYFFTf7 (ORCPT ); Fri, 6 Jun 2008 15:35:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755585AbYFFTft (ORCPT ); Fri, 6 Jun 2008 15:35:49 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37899 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755537AbYFFTfs (ORCPT ); Fri, 6 Jun 2008 15:35:48 -0400 Date: Fri, 6 Jun 2008 12:35:11 -0700 From: Andrew Morton To: Matthew Garrett Cc: greg@kroah.com, justinmattock@gmail.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] isight_firmware: Avoid crash on loading invalid firmware Message-Id: <20080606123511.38ffbdde.akpm@linux-foundation.org> In-Reply-To: <20080606192135.GA16727@srcf.ucam.org> References: <20080606002601.a0f6c47c.akpm@linux-foundation.org> <20080606121136.GA9087@srcf.ucam.org> <20080606110711.a9a6a4f6.akpm@linux-foundation.org> <20080606185548.GB8576@kroah.com> <20080606192135.GA16727@srcf.ucam.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 16 On Fri, 6 Jun 2008 20:21:35 +0100 Matthew Garrett wrote: > Different tools generate slightly different formats of the isight > firmware. Ensure that the firmware buffer is not overrun, while still > ensuring that the correct amount of data is written if trailing data is > prseent. It would have been nice to have mentioned this Justin Maddock fellow in the changelog. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/