Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760341AbYFGBIW (ORCPT ); Fri, 6 Jun 2008 21:08:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756225AbYFGBGG (ORCPT ); Fri, 6 Jun 2008 21:06:06 -0400 Received: from saeurebad.de ([85.214.36.134]:58060 "EHLO saeurebad.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756124AbYFGBGE (ORCPT ); Fri, 6 Jun 2008 21:06:04 -0400 From: Johannes Weiner To: Matthew Garrett Cc: Andrew Morton , greg@kroah.com, justinmattock@gmail.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] isight_firmware: Avoid crash on loading invalid firmware References: <20080606002601.a0f6c47c.akpm@linux-foundation.org> <20080606121136.GA9087@srcf.ucam.org> <20080606110711.a9a6a4f6.akpm@linux-foundation.org> <20080606185548.GB8576@kroah.com> <20080606192135.GA16727@srcf.ucam.org> <20080606123511.38ffbdde.akpm@linux-foundation.org> <20080606194856.GA17708@srcf.ucam.org> Date: Sat, 07 Jun 2008 03:05:16 +0200 In-Reply-To: <20080606194856.GA17708@srcf.ucam.org> (Matthew Garrett's message of "Fri, 6 Jun 2008 20:48:56 +0100") Message-ID: <873anq5a2b.fsf@saeurebad.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 617 Lines: 15 Matthew Garrett writes: > Different tools generate slightly different formats of the isight > firmware. Ensure that the firmware buffer is not overrun, while still > ensuring that the correct amount of data is written if trailing data is > preseent. Fixes crash reported by Justin Mattock. You don't like the word `present', do you? ;) Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/