Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758986AbYFGCrQ (ORCPT ); Fri, 6 Jun 2008 22:47:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754848AbYFGCqv (ORCPT ); Fri, 6 Jun 2008 22:46:51 -0400 Received: from yw-out-2324.google.com ([74.125.46.28]:56537 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988AbYFGCqu (ORCPT ); Fri, 6 Jun 2008 22:46:50 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=OBO0z0JBK2hGyGQvxQCYLAXm9+sulwCdlczDWFxXVxL3sViWVpUhjiUZUlK5VMABFB LP8IlClpZ3ghXm0bjK4XghqADpJ6v+5w6YmYxtBPpFp/2OvmDTJOESWh7ZdC2uGN+89D Yj8BIE+Q00oN2gb3HMuoU8bj5zMi8TnUDdEWA= Message-ID: <386072610806061946q178daa09ge8b97568565c179c@mail.gmail.com> Date: Sat, 7 Jun 2008 10:46:49 +0800 From: "Bryan Wu" To: "Mike Frysinger" Subject: Re: serial/bfin_5xx.c build error Cc: "Adrian Bunk" , "Graf Yang" , sonic.zhang@analog.com, "Alan Cox" , linux-kernel@vger.kernel.org In-Reply-To: <8bd0f97a0806061253s4ad62aa8j53b448b3d6a4faf4@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080606162203.GB2201@cs181133002.pp.htv.fi> <386072610806060940r5bea0549va4a0a1ae587777bf@mail.gmail.com> <8bd0f97a0806061253s4ad62aa8j53b448b3d6a4faf4@mail.gmail.com> X-Google-Sender-Auth: 2cbebed81316ee88 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 37 On Sat, Jun 7, 2008 at 3:53 AM, Mike Frysinger wrote: > On Fri, Jun 6, 2008 at 12:40 PM, Bryan Wu wrote: >> On Sat, Jun 7, 2008 at 12:22 AM, Adrian Bunk wrote: >>> Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8 >>> (Blackfin Serial Driver: Enable IR function when user application) >>> causes the following build error: >>> >>> <-- snip --> >>> >>> ... >>> CC drivers/serial/bfin_5xx.o >>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init': >>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc' >>> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1 >>> >>> <-- snip --> >>> >>> In case it can't be fixed quickly a revert might be an option for 2.6.26. >>> >> >> Graf has already sent me a patch to fix this. After I test it on my >> board, I will send it out for Linus git pull. > > i dont think there's anything for us to do on our side. i thought > Alan was sending the fix out for 2.6.26. > -mike > Oh, no. Even with Alan and Linus pathc, we still need to fix some API change. I will send it out soon. -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/