Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756351AbYFGDOg (ORCPT ); Fri, 6 Jun 2008 23:14:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753601AbYFGDOZ (ORCPT ); Fri, 6 Jun 2008 23:14:25 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:51080 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbYFGDOY (ORCPT ); Fri, 6 Jun 2008 23:14:24 -0400 Message-ID: <4849FD02.9000901@garzik.org> Date: Fri, 06 Jun 2008 23:14:10 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Linus Torvalds CC: Chris Wright , linux-kernel@vger.kernel.org, stable@kernel.org, IDE/ATA development list , Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Tejun Heo , matthieu.castet@parrot.com, Greg Kroah-Hartman Subject: Re: [patch 10/50] libata: force hardreset if link is in powersave mode References: <20080607010215.358296706@sous-sol.org> <20080607010555.470605116@sous-sol.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 859 Lines: 27 Linus Torvalds wrote: > > On Fri, 6 Jun 2008, Chris Wright wrote: >> -stable review patch. If anyone has any objections, please let us know. >> --------------------- >> >> From: Tejun Heo >> >> Inhibiting link PM mode doesn't bring the link back online if it's >> already in powersave mode. If SRST is used in these cases, libata EH >> thinks that the link is offline and fails detection. Force hardreset >> if link is in powersave mode. > > This isn't upstream. Maybe there's some reason it's not needed upstream, > but it would be nice to know. We do hard reset by default... Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/