Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755145AbYFGEtd (ORCPT ); Sat, 7 Jun 2008 00:49:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751590AbYFGEtU (ORCPT ); Sat, 7 Jun 2008 00:49:20 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:32992 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbYFGEs4 (ORCPT ); Sat, 7 Jun 2008 00:48:56 -0400 Date: Sat, 07 Jun 2008 13:44:07 +0900 From: KOSAKI Motohiro To: Keika Kobayashi Subject: Re: [PATCH 2/3 v2] per-task-delay-accounting: update taskstats for memory reclaim delay Cc: kosaki.motohiro@jp.fujitsu.com, balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, nagar@watson.ibm.com, balbir@in.ibm.com, sekharan@us.ibm.com, kamezawa.hiroyu@jp.fujitsu.com In-Reply-To: <20080606172437.bcd7d98a.kobayashi.kk@ncos.nec.co.jp> References: <4848B983.4030502@linux.vnet.ibm.com> <20080606172437.bcd7d98a.kobayashi.kk@ncos.nec.co.jp> Message-Id: <20080607134129.9C40.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 32 > Add members for memory reclaim delay to taskstats, > and accumulate them in __delayacct_add_tsk() . > > Signed-off-by: Keika Kobayashi > --- > > Balbir Singh wrote: > > > Two suggested changes > > > > 1. Please add all fields at the end (otherwise we risk breaking compatibility) > > 2. please also update Documentation/accounting/taskstats-struct.txt > > > > Thanks for your suggestion. > Update version is here. > > In taskstats-struct.txt, there was not a discription for "Time accounting for SMT machines". > This patch was made after the following patch had been applied. > http://lkml.org/lkml/2008/6/6/436 . The code of this patch looks good to me. but this change log isn't so good. Do you want remain email bare discssion on git log? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/