Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758759AbYFGG4a (ORCPT ); Sat, 7 Jun 2008 02:56:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754038AbYFGG4T (ORCPT ); Sat, 7 Jun 2008 02:56:19 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45101 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753939AbYFGG4S (ORCPT ); Sat, 7 Jun 2008 02:56:18 -0400 Date: Fri, 6 Jun 2008 23:55:26 -0700 From: Andrew Morton To: "Justin Mattock" Cc: "Rafael J. Wysocki" , "Linux Kernel Mailing List" , linux-acpi@vger.kernel.org, Alexey Starikovskiy Subject: Re: ACPI: EC: GPE storm detected, disabling EC GPE Message-Id: <20080606235526.783acc83.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2405 Lines: 64 On Sat, 7 Jun 2008 06:21:54 +0000 "Justin Mattock" wrote: > Well; I was hoping it was going to be just an easy fix, but unfortunately > changing > if (atomic_read(&ec->irq_count) > 5) { > to > if (atomic_read(&ec->irq_count) > 20) { > does seem to make the message disappear, for a while, probably at > around three hours,(for me at least) then the message appeared again. > :-( > So leaving me back to the beginning of try to have a go at this. > regards; I removed bugzilla from cc - that only works if there's [Bug 1234] in the Subject:. I added linux-acpi to cc - this is an acpi problem. What Justin is mysteriously referring to here is: : From: "Justin Mattock" : To: "Linux Kernel Mailing List" : Cc: "Rafael J. Wysocki" : Subject: GPE storm detected, disabling EC GPE : Date: Thu, 5 Jun 2008 21:01:55 +0000 : Sender: linux-kernel-owner@vger.kernel.org : : FWIW I noticed a post where the person had changed 5 to 20, and it : seemed to work for them; : So with that in mind I decide to give that a go, here is the location: : drivers/acpi/ec.c : @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data) : { : acpi_status status = AE_OK; : struct acpi_ec *ec = data; : u8 state = acpi_ec_read_status(ec); : : pr_debug(PREFIX "~~~> interrupt\n"); : atomic_inc(&ec->irq_count); : - if (atomic_read(&ec->irq_count) > 5) { : + if (atomic_read(&ec->irq_count) > 20) { : pr_err(PREFIX "GPE storm detected, disabling EC GPE\n"); : ec_switch_to_poll_mode(ec); : goto end; : } : : Now I don't know if this will work for other brands, but for : me(Macbook Pro ATI chipset) I have not received the : GPE storm detected, disabling EC GPE message, but it's only been an : hour, maybe after two or three this might appear. : Also is this good or bad to set 5 to 20 for the system? Could someone from acpi land please help here? Justin, has this machine always had this problem or is it something which earlier kernels handled correctly? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/