Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757833AbYFGW05 (ORCPT ); Sat, 7 Jun 2008 18:26:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752067AbYFGW0t (ORCPT ); Sat, 7 Jun 2008 18:26:49 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48038 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbYFGW0t (ORCPT ); Sat, 7 Jun 2008 18:26:49 -0400 Date: Sat, 7 Jun 2008 15:26:12 -0700 (PDT) From: Linus Torvalds To: Pavel Machek cc: Alan Stern , Linus Torvalds , gregkh@suse.de, Andrew Morton , kernel list , Oliver Neukum Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on In-Reply-To: <20080607195221.GB11109@ucw.cz> Message-ID: References: <20080606092546.GA2596@elf.ucw.cz> <20080607195221.GB11109@ucw.cz> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 23 On Sat, 7 Jun 2008, Pavel Machek wrote: > > Well, not-usb-persists means we force-unplug disks during suspend, > after syncing them. Not _too_ bad. > > If you unplug disk while hibernated, modify it, and plug it back, > youget _silent_ filesystem corruption. I call that bad. .. and if the USB layer unplugs them unconditionally while the filesystem is mounted, you _unconditionally_ get a system that doesn't work. I call that worse. Much worse. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/