Message-ID: <484C83D9.2020402@kernel.org>
Date: Sun, 08 Jun 2008 18:14:01 -0700
From: "H. Peter Anvin" <hpa@kernel.org>
Organization: Linux Kernel Organization, Inc.
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
CC: Adrian Bunk <bunk@kernel.org>,
       =?UTF-8?B?IlMuw4dhxJ9sYXIgT251ciI=?= <caglar@pardus.org.tr>,
       linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Frank Seidel <fseidel@suse.de>,
       =?UTF-8?B?T251ciBLw7zDp8O8aw==?= <onur@pardus.org.tr>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6.26 patch] fat_valid_media() isn't for userspace
References: <200806082116.50355.caglar@pardus.org.tr>	<20080608184310.GD4048@cs181133002.pp.htv.fi> <87prqrn4d8.fsf@duaron.myhome.or.jp>
In-Reply-To: <87prqrn4d8.fsf@duaron.myhome.or.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 960
Lines: 27

OGAWA Hirofumi wrote:
> 
> Yes. This is new one, so it shouldn't have any users of that.
> Looks more better. Thanks.
> 

The other thing about this header that needs to be fixed is the 
definition of the following ioctls:

#define VFAT_IOCTL_READDIR_BOTH         _IOR('r', 1, struct dirent [2])
#define VFAT_IOCTL_READDIR_SHORT        _IOR('r', 2, struct dirent [2])

"struct dirent" is a kernel type here, but is a **different type** in 
userspace!  This means both the structure and the IOCTL number is wrong!

We need to make this either __kernel_dirent_t[*] or something like 
struct __msdos_fs_dirent.

	-hpa

[*] Yes, typedefs suck, but unfortunately C doesn't allow aliases in the 
structure tag namespace.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/