Date: Mon, 9 Jun 2008 07:16:48 -0700 (PDT)
From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
cc: Eric Dumazet <dada1@cosmosbay.com>, kosaki.motohiro@jp.fujitsu.com,
       nickpiggin@yahoo.com.au, hugh@veritas.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmallocinfo: Add NUMA informations
In-Reply-To: <20080603144054.973284bb.akpm@linux-foundation.org>
Message-ID: <Pine.LNX.4.64.0806090715020.29723@schroedinger.engr.sgi.com>
References: <48439916.2070108@cosmosbay.com> <20080602160548.B6D4.KOSAKI.MOTOHIRO@jp.fujitsu.com>
 <4844BC75.8040705@cosmosbay.com> <20080603144054.973284bb.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 892
Lines: 23

On Tue, 3 Jun 2008, Andrew Morton wrote:

> > +	if (NUMA_BUILD) {
> > +		unsigned int *counters, nr;
> > +
> > +		counters = kzalloc(nr_node_ids * sizeof(unsigned int),
> 
> This is kcalloc().  If you like that sorts of thing - I think kcalloc()
> is pretty pointless personally.

Same here. I think its generally ignored. I tried to remove it at some 
point in the past. If we want kcalloc then we also need kczalloc. It would 
be best to keep the interface simple.

> Do we actually need dynamic allocation here?  There's a small,
> constant, known-at-compile-time upper bound to the number of nodes IDs?

The number of node ids may reach 1024.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/