Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761810AbYFIPMi (ORCPT ); Mon, 9 Jun 2008 11:12:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754079AbYFIPMb (ORCPT ); Mon, 9 Jun 2008 11:12:31 -0400 Received: from smtp-out003.kontent.com ([81.88.40.217]:53668 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753882AbYFIPMb (ORCPT ); Mon, 9 Jun 2008 11:12:31 -0400 From: Oliver Neukum Organization: NOvell To: Alan Stern Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on Date: Mon, 9 Jun 2008 17:12:45 +0200 User-Agent: KMail/1.9.9 Cc: Pavel Machek , Linus Torvalds , Linus Torvalds , gregkh@suse.de, Andrew Morton , kernel list , "Rafael J. Wysocki" References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806091712.46869.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1138 Lines: 28 Am Montag 09 Juni 2008 17:03:10 schrieb Alan Stern: > On Mon, 9 Jun 2008, Pavel Machek wrote: > > > Besides, it seems to break suspend/resume of printers, and probably > > all the drivers that do not have reset_resume() method. That's > > actually a regression. > > > > https://bugzilla.novell.com/show_bug.cgi?id=394820 > > The right way to fix this is to add reset_resume to the printer driver. reset_resume() is supposed to restore all state. The printer driver does not know which state a printer is in, except for the trivial case of the printer not being in use, as it doesn't know the meaning of the data going to the printer. You might argue that you deserve what you get when you hibernate while printing, but then it makes no sense to implement it anyhow, disconnection and reconnection work just as well and are cleaner. The same is true for many devices. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/