Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045AbYFIPkz (ORCPT ); Mon, 9 Jun 2008 11:40:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751359AbYFIPkn (ORCPT ); Mon, 9 Jun 2008 11:40:43 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42395 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbYFIPkm (ORCPT ); Mon, 9 Jun 2008 11:40:42 -0400 Date: Mon, 9 Jun 2008 08:35:20 -0700 (PDT) From: Linus Torvalds To: Pavel Machek cc: Alan Stern , gregkh@suse.de, Andrew Morton , kernel list , Oliver Neukum , "Rafael J. Wysocki" Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on In-Reply-To: <20080609080052.GA27899@elf.ucw.cz> Message-ID: References: <20080606092546.GA2596@elf.ucw.cz> <20080607195221.GB11109@ucw.cz> <20080609080052.GA27899@elf.ucw.cz> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 32 On Mon, 9 Jun 2008, Pavel Machek wrote: > > If your device did not loose power during s2ram, it should just work. Tough. And if pigs had wings, they could fly. What's your point? > There's a tweak you can set in /sys you can set if your device is not > removable, you can set it for non-removable devices that _do_ loose > power. Yes, and it's totally pointless. I had this whole discussion already. That flag is too hard to find for any normal person to be useful, and the fact is, if you hold the device mounted over a suspend, it should be set by default anyway. > Besides, it seems to break suspend/resume of printers, and probably > all the drivers that do not have reset_resume() method. That's > actually a regression. > > https://bugzilla.novell.com/show_bug.cgi?id=394820 So printers shouldn't do it, since they aren't mounted. Neither should mice etc things. What does that have to do with block devices? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/