Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754171AbYFIQQw (ORCPT ); Mon, 9 Jun 2008 12:16:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750811AbYFIQQl (ORCPT ); Mon, 9 Jun 2008 12:16:41 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:60147 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbYFIQQk (ORCPT ); Mon, 9 Jun 2008 12:16:40 -0400 Date: Mon, 9 Jun 2008 18:16:06 +0200 From: Ingo Molnar To: Marin Mitov Cc: LKML , Steven Rostedt , Thomas Gleixner , linux-rt-users , akpm@osdl.org, Clark Williams , Peter Zijlstra , "Luis Claudio R. Goncalves" , Gregory Haskins , Linus Torvalds , Andi Kleen Subject: Re: [PATCH][resubmit] x86: enable preemption in delay Message-ID: <20080609161606.GA24841@elte.hu> References: <200805252108.25011.mitov@issp.bas.bg> <200806011901.23619.mitov@issp.bas.bg> <20080609121309.GA13610@elte.hu> <200806091911.21850.mitov@issp.bas.bg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200806091911.21850.mitov@issp.bas.bg> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.3 _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 36 * Marin Mitov wrote: > > i think Thomas had a concern with the original fix - forgot the > > details. > > Here they are: > > http://lkml.org/lkml/2008/5/25/251 > > but see my comment to it. > > There is no principal difference between both patches. I have seen > Steven's one as merged in linux-2.6.26-rc5. The only difference (if it > matters of all) is that in mine patch > preempt_disable()/preempt_enable() sections are shorter and protect > only the code that must be protected: > > preempt_disable() > rdtscl() > smp_processor_id() > preempt_enable() > > As far as Steven's patch is already merged - let it be :-) we could still merge your enhancements as well ontop of Steven's, if you would like to pursue it. If so then please send a patch against -rc5 or against -tip. Reducing the length of preempt-off sections is a fair goal. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/